[explore] set working default for MetricsControl #4803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default setting which would look for either `count` first and then any metric stopped working when we landed MetricsControl. This mimics the previous behavior
Codecov Report
@@ Coverage Diff @@
## master #4803 +/- ##
==========================================
+ Coverage 72.33% 72.33% +<.01%
==========================================
Files 208 208
Lines 15519 15521 +2
Branches 1202 1202
==========================================
+ Hits 11225 11227 +2
Misses 4291 4291
Partials 3 3
Continue to review full report at Codecov.
|
michellethomas
pushed a commit
to michellethomas/panoramix
that referenced
this pull request
May 24, 2018
The default setting which would look for either `count` first and then any metric stopped working when we landed MetricsControl. This mimics the previous behavior
timifasubaa
pushed a commit
to timifasubaa/incubator-superset
that referenced
this pull request
May 31, 2018
The default setting which would look for either `count` first and then any metric stopped working when we landed MetricsControl. This mimics the previous behavior
wenchma
pushed a commit
to wenchma/incubator-superset
that referenced
this pull request
Nov 16, 2018
The default setting which would look for either `count` first and then any metric stopped working when we landed MetricsControl. This mimics the previous behavior
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default setting which would look for either
countfirst and thenany metric stopped working when we landed MetricsControl. This mimics
the previous behavior.
👀 @GabeLoins